Skip to content

ci!: parallelize validation and promote tested image candidates - #553

Merged
neilime merged 68 commits into
mainfrom
ci/475-p1-local-reductions
Nov 17, 2026
Merged

neilime merged 68 commits into
mainfrom
ci/475-p1-local-reductions

Conversation

@neilime

@neilime neilime commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Build CI images and production candidates independently, validate both applications and the exact candidate digests with Helm, then promote consumer tags only after every required check succeeds. This removes duplicate compilation and serial waits while preserving reports, signatures, provenance and fail-closed publication.

  • Backend/frontend checks run independently with CPU-adaptive test workers. The local routing package is tested separately. Documentation-only PRs retain repository lint and Actions security checks; main and releases run full CI. Validate PR checks verifies the expected job set and allowed skips.
  • Helm has separate prepare, lint, test and publication contracts. Release publication consumes the exact validated artifact ID, archive name and checksum. Test configuration belongs to validation. Generated-doc change detection and formatting use the released bundled action.
  • Common 4.2.4, Node.js 3.1.0, Container 4.2.0 and Publish 3.0.7 are pinned to immutable release commits. Sharding, paid runners, shared builders, registry caches and cross-run release-image reuse remain rejected or deferred where measurements or metadata contracts do not justify adoption.

P8 acceptance freezes runtime revision f30bb34. Five consecutive full CI samples, after a separate primer, all pass:

Metric P0 median Final median Historical change
Elapsed 15m 31s 7m 51s 49.4% lower
Summed job time 26m 58s 21m 29s 20.3% lower

Final elapsed range is 6m 21s-8m 33s. This is a historical comparison, not an isolated causal estimate: dependencies, tooling and runner images changed between P0 and P8. The ADR retains controlled phase comparisons and all slow/unsuccessful samples. Summed execution is not billing.

All 235 application build instructions across the twenty warm builds hit the cache. JUnit/LCOV preserve 1,178 passing frontend tests, 1,230 passing backend tests and 60 existing backend skips, with identical application coverage denominators. The 40 relocated routing cases match the former backend cases. All ten production digest handoffs match attestation, Helm installation and promotion. A real dependency-bot distribution update is verified in Publish #516.

Isolated cold and final-chart validation passes all 31 executed jobs. All four application builds disable layer imports/exports and mount persistence; all 47 build instructions execute without cache hits. Test inventories/coverage denominators match warm execution. The extra final-chart job validates release versions and promoted image defaults, uploads the exact tested archive, and passes checksum/content inspection. Both clusters and prepared archives are cleaned. It publishes no chart or GitHub release.

Review the P8 evidence, checkbox plan and current recovery guidance. This phase changes documentation only; raw evidence and the temporary validation workflow stay outside this PR.

Rollout remains open: successful main CI and bot publication/cancellation checks, required-check enforcement, and the next legitimate Pleey release. Generated-doc commits currently use [skip ci]; requiring Validate PR checks needs an approved bot bypass or a change to the bot workflow. The ADR proposes a main-only rule with a PR-only exemption for the existing bot app, explains the trade-off and leaves repository rules unchanged. No Pleey release is published for benchmarking.

The final validation run passed in 16m 03s (30m 38s summed job time) and contains a retained setup outlier: docker/setup-buildx-action took 600.6s, including a 579.3s pause after printing its BuildKit version. The subsequent backend build hit all 15 cached application instructions; all four builds hit all 47 instructions. The cause remains unestablished; this is outside the predefined five-attempt benchmark and is not discarded or presented as a layer-cache miss.

Local validation: Markdown formatting/lint, 128 local links/anchors and git diff --check pass. Native CI for documentation commit aadc07a passes all 32 executed jobs with 28 expected nested skips. Runtime files match the measured revision.

Refs #475; this PR does not close the issue.

@github-actions github-actions Bot added the type: maintenance Performs maintenance work label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Super-linter summary

Language Validation result
CHECKOV Pass ✅
DOCKERFILE_HADOLINT Pass ✅
GITHUB_ACTIONS Pass ✅
GITHUB_ACTIONS_ZIZMOR Pass ✅
GITLEAKS Pass ✅
GIT_COMMITLINT Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
JSCPD Pass ✅
KUBERNETES_KUBECONFORM Pass ✅
MARKDOWN Pass ✅
MARKDOWN_PRETTIER Pass ✅
NATURAL_LANGUAGE Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter
Super-linter revision: 2da136927bd4a73596db63044b504547c62cb854
Super-linter version: 9.0.0

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Code Coverage Report

Coverage Results

Test Results

Status Count
✅ Passed 1178
❌ Failed 0
⏭️ Skipped 0
Total 1178
Suite Passed Failed Skipped
scripts/check-presentation-screens.spec.ts 7 0 0
src/app/bootstrap/app-providers.spec.tsx 2 0 0
src/app/bootstrap/create-app-container.spec.ts 7 0 0
src/app/bootstrap/modules/identity/app-auth-provider-factory.spec.tsx 14 0 0
src/app/bootstrap/modules/party/services/app-party-game-type-runtime-registry.spec.ts 4 0 0
src/app/bootstrap/modules/party/services/prediction-party-game-type-runtime-view.spec.tsx 2 0 0
src/app/routing/route-registry.spec.tsx 9 0 0
src/application/game/management/use-cases/list-project-games-use-case.spec.ts 1 0 0
src/application/game/party/host/services/host-party-runtime-controls-resolver.spec.ts 1 0 0
src/application/game/party/shared/facades/party-lobby.facade.spec.ts 2 0 0
src/application/game/party/shared/services/identifiers/party-pin-identifier.spec.ts 3 0 0
src/application/game/party/shared/services/party-route.service.spec.ts 8 0 0
src/application/game/types/prediction/facades/prediction-management.facade.spec.ts 1 0 0
src/application/game/types/quiz/facades/quiz-management.facade.spec.ts 1 0 0
src/application/game/types/shared/services/game-type-registry.spec.ts 6 0 0
src/application/shared/services/collect-paginated-items.spec.ts 7 0 0
src/application/shared/services/identifier-parser/uuid-v7-identifier-parser.spec.ts 4 0 0
src/application/workspace/dashboard/facades/dashboard-home-actions.facade.spec.ts 6 0 0
src/application/workspace/dashboard/facades/dashboard-workspace.facade.spec.ts 7 0 0
src/application/workspace/organizations/use-cases/get-organization-dashboard-use-case.spec.ts 1 0 0
src/application/workspace/shared/services/identifiers/organization-identifier.spec.ts 4 0 0
src/application/workspace/shared/services/identifiers/project-identifier.spec.ts 3 0 0
src/application/workspace/themes/services/theme-identifier.spec.ts 30 0 0
src/domains/game/types/shared/static-game-type-catalog.spec.ts 2 0 0
src/domains/identity/services/auth-payload-inspector.spec.ts 4 0 0
src/domains/shared/errors/domain-error.spec.ts 2 0 0
src/domains/shared/services/action-permission-decoder.spec.ts 10 0 0
src/domains/theme/services/theme-document-normalizer.spec.ts 18 0 0
src/domains/theme/services/theme-palette-generator.spec.ts 14 0 0
src/i18n/config/init.spec.ts 4 0 0
src/i18n/translation-resource-composer.spec.ts 10 0 0
src/infrastructure/config/app-env-reader.spec.ts 9 0 0
src/infrastructure/forms/tanstack-form-adapter.spec.tsx 1 0 0
src/infrastructure/game/management/graphql-game-catalog.adapter.spec.ts 2 0 0
src/infrastructure/game/party/crypto-private-party-password-generator.adapter.spec.ts 3 0 0
src/infrastructure/game/party/player/persisted-party-guest-session.adapter.spec.ts 9 0 0
src/infrastructure/game/party/player/unique-username-guest-username-generator.adapter.spec.ts 3 0 0
src/infrastructure/game/party/shared/socket-io-party-observation.adapter.spec.ts 27 0 0
src/infrastructure/game/party/shared/socket-io-party-realtime-transport.spec.ts 17 0 0
src/infrastructure/game/types/prediction/graphql-prediction-management.repository.spec.ts 1 0 0
src/infrastructure/game/types/quiz/graphql-quiz-management.repository.spec.ts 1 0 0
src/infrastructure/game/types/shared/playable-management-graphql.mapper.spec.ts 1 0 0
src/infrastructure/graphql/client/graphql-client.spec.ts 22 0 0
src/infrastructure/i18n/react-i18next-translation.adapter.spec.tsx 2 0 0
src/infrastructure/identity/cap-widget.adapter.spec.tsx 3 0 0
src/infrastructure/identity/graphql-auth-repository.spec.ts 4 0 0
src/infrastructure/identity/persisted-auth-session.adapter.spec.ts 10 0 0
src/infrastructure/media/authorized-media-access.adapter.spec.ts 4 0 0
src/infrastructure/organization/graphql-organization-repository.spec.ts 13 0 0
src/infrastructure/project/graphql-project-repository.spec.ts 8 0 0

178 additional suites are available in the native reports.

✅ Pass Rate: 100.0%

Coverage

Metric Covered Total Percentage
Lines 6916 8296 83.37%
Branches 4151 5496 75.53%
Functions 2018 2465 81.87%

Overall: 83.37% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜⬜⬜

@neilime neilime changed the title ci: reduce duplicate builds and validation overhead for P1 ci!: reduce duplicate builds and validation overhead for P1 Nov 6, 2026
@neilime
neilime marked this pull request as ready for review November 6, 2026 13:11
@github-actions github-actions Bot added the type: breaking Introduces a breaking change label Nov 6, 2026
@neilime neilime changed the title ci!: reduce duplicate builds and validation overhead for P1 ci!: reduce validation overhead and adopt released CI tooling Nov 10, 2026
@neilime
neilime force-pushed the ci/475-p1-local-reductions branch from daa2ba4 to 9f35667 Compare November 10, 2026 21:19
@neilime neilime changed the title ci!: reduce validation overhead and adopt released CI tooling ci!: streamline validation and parallelize service checks Nov 11, 2026
@neilime neilime changed the title ci!: streamline validation and parallelize service checks ci!: parallelize validation and promote tested image candidates Nov 12, 2026
Record the five-run comparison, local fault checks and worker controls.
Complete the P1 checklist and preserve the remaining upstream work.

BREAKING CHANGE: backend.waitForDatabase.image overrides are removed.
Database readiness now uses the backend workload image; remove those
BusyBox overrides when upgrading the chart.
Use the released Node, common, container and publish workflows.
Preserve explicit report paths and the prepared release commit with
its target-ref input. Align local lint and record the P2 adoption
protocol in ADR 0023.
Comment thread .github/workflows/main-ci.yml Resolved
Comment thread .github/workflows/pull-request-ci.yml Resolved
Comment thread .github/workflows/pull-request-ci.yml Resolved
Comment thread .github/workflows/release.yml Resolved
Comment thread .github/workflows/release.yml Resolved
Comment thread .github/workflows/release.yml Resolved
@neilime
neilime merged commit b9c798e into main Nov 17, 2026
66 checks passed
@neilime
neilime deleted the ci/475-p1-local-reductions branch November 17, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: breaking Introduces a breaking change type: maintenance Performs maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant