Skip to content

Update go version - #412

Merged
mmorhun merged 2 commits into
mainfrom
update-go-version
Oct 23, 2026
Merged

mmorhun merged 2 commits into
mainfrom
update-go-version

Conversation

@mmorhun

@mmorhun mmorhun commented Oct 23, 2026

Copy link
Copy Markdown
Member

Description

Update golang to version 1.26.10 and some dependencies

@mmorhun mmorhun self-assigned this Oct 23, 2026
@mmorhun
mmorhun requested a review from a team as a code owner October 23, 2026 14:23
@qodo-app-for-konflux-ci

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Powered by Qodo

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun
mmorhun merged commit 80258dd into main Oct 23, 2026
22 checks passed
@mmorhun
mmorhun deleted the update-go-version branch October 23, 2026 17:37
@fullsend-ai-retro

fullsend-ai-retro Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 5:38 PM UTC · Completed 5:50 PM UTC

Commit: d55bd06 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.85

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #412 — Update Go version

Workflow outcome: No agent review ran. This is expected — the review role was intentionally removed from .fullsend/config.yaml on 2026-10-02 (issue #397) because auto-triggered review on every PR created noise, particularly on bot-authored dependency updates. The all-or-nothing role mechanism meant disabling auto-review also disabled on-demand /fs-review.

Timeline

  1. 14:23 UTC — PR opened by mmorhun (Go 1.25→1.26.10, dependency updates, base image bumps)
  2. 14:24 UTC — Workflow run: routed to review, skipped — role not in configured roles
  3. 14:30 UTC — rcerven approved (no comments, appropriate for a routine dependency update)
  4. 16:41 UTC — Workflow run: PR synchronize → review, skipped again
  5. 17:37 UTC — PR merged; retro dispatched

Key finding

The upstream blocker that forced the all-or-nothing disable — fullsend-ai/fullsend#2078 — was closed as COMPLETED today. Granular CEL-based trigger control now exists (shipping after v0.49.0, per #8733 and #8737). The repo can re-enable on-demand review (/fs-review) without auto-triggering on every PR open/sync, once it upgrades past v0.49.0 (currently on v0.43.0; PR #401 updates to v0.48.1).

Assessment

The workflow worked correctly for this PR. A routine dependency update with no production code changes is low-signal for agent review — the human approval was appropriate. No token waste occurred (no agent review dispatched). One proposal below to restore on-demand review coverage once the version prerequisite is met.

Proposals filed

@konflux-ci-qe-bot

Copy link
Copy Markdown

Scenario: konflux-e2e-image-controller
@mmorhun: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
konflux-e2e-image-controller-lf9jw Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/image-controller:konflux-e2e-image-controller-lf9jw

Test results analysis

🚨 Error occurred while running the E2E tests, list of failed Spec(s):

➡️ [failed] [It] [image-controller-suite Image Controller E2E tests] image repository different status states update push secret name to a empty string and check state is changed to damaged [image-controller, status-state]

Click to view logs

failed while trying to add a dummy annotation to the image repository "image-repository-rcaw"
Unexpected error:
    <*errors.StatusError | 0x20ef3a9a2820>: 
    Operation cannot be fulfilled on imagerepositories.konflux-ci.dev "image-repository-rcaw": the object has been modified; please apply your changes to the latest version and try again
    {
        ErrStatus: {
            TypeMeta: {Kind: "", APIVersion: ""},
            ListMeta: {
                SelfLink: "",
                ResourceVersion: "",
                Continue: "",
                RemainingItemCount: nil,
            },
            Status: "Failure",
            Message: "Operation cannot be fulfilled on imagerepositories.konflux-ci.dev \"image-repository-rcaw\": the object has been modified; please apply your changes to the latest version and try again",
            Reason: "Conflict",
            Details: {
                Name: "image-repository-rcaw",
                Group: "konflux-ci.dev",
                Kind: "imagerepositories",
                UID: "",
                Causes: nil,
                RetryAfterSeconds: 0,
            },
            Code: 409,
        },
    }
occurred

OCI Artifact Browser URL

View in Artifact Browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants