Terminate on unsupported challenge version instead of sending code 2 - #40
Open
markmnl wants to merge 1 commit into
Open
Terminate on unsupported challenge version instead of sending code 2#40markmnl wants to merge 1 commit into
markmnl wants to merge 1 commit into
Conversation
A challenger's next read after sending CHALLENGE is exactly the 32-byte CHALLENGE-RESPONSE hash, so a response code written into that stream is indistinguishable from the start of a hash. Close without responding (SPEC SS10.5); code 2 remains for unsupported MESSAGE versions, where the peer's first read is always a response code. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design correction from spec review (markmnl/fmsg#29,
49585f7): the listener's response to an unsupported first byte must depend on who is listening on the other end.readVersionOrChallengenow closes without writing on this branch.The earlier v0.5.0 spec draft had unified both branches to code 2 (matching fmsgd's then-behaviour); the spec has been corrected to keep the original TERMINATE for the challenge branch, and this PR brings fmsgd in line.
🤖 Generated with Claude Code