Skip to content

Terminate on unsupported challenge version instead of sending code 2 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markmnl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Terminate on unsupported challenge version instead of sending code 2 #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/fmsgd/host.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,9 +693,9 @@ func readVersionOrChallenge(c net.Conn, r *bufio.Reader, h *FMsgHeader) (bool, e
if challengeVersion == 1 {
return true, handleChallenge(c, r)
}
if err := sendCode(c, RejectCodeUnsupportedVersion); err != nil {
log.Printf("WARN: failed to send unsupported version response: %s", err)
}
// TERMINATE without responding (SPEC §10.3/§10.5): the challenger's
// next read is exactly the 32-byte CHALLENGE-RESPONSE hash, so a
// response code here would be indistinguishable from hash bytes.
return false, fmt.Errorf("unsupported challenge version: %d", challengeVersion)
}
if v != 1 {
Expand Down
Loading