Repository navigation
The cv of the Fisher information is the relative error of the parameter - #339
Merged
Merged
Conversation
The column cv of FisherInformation.summary_df divided the standard error in the space of the optimizer by the value in that space: for a parameter searched as log10 it was se(log10 p)/|log10 p|, which depends on the unit of the parameter and is near infinite for a value near 1 (HCTZ: Emax_hctz_cl 1.15 had 134 %, E50 1.85e-4 mM 2.7 %, where the relative errors are about 19 and 24 %). It is now the relative error of the parameter in the units of the model, to first order: se/|p| on the linear scale, se(ln p) for ln and ln(10) se(log10 p) for log10 (FisherInformation.relative_errors). The description of the column in the report says so. Fixes #338.
This was referenced Oct 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #338.
The column
cvofFisherInformation.summary_df(fisher.tsv, the report) wasse / |value|in the space of the optimizer, i.e.se(log10 p) / |log10 p|for a parameter searched as log10: it depended on the unit of the parameter and was near infinite for a value near 1 (pkdb_models HCTZ:Emax_hctz_cl1.15 had 134 %,E50_hctz_nacl1.85e-4 mM 2.7 %, the relative errors are about 19 and 24 %).Now
FisherInformation.relative_errorsgives the relative error of the parameter in the units of the model, to first order:se / |p|(linear),se(ln p)(log),ln(10) se(log10 p)(log10);cvis it in percent, and the report describes the column accordingly.Tests:
tests/fit/test_fisher.py(a test per scale, including the HCTZ values),pytest tests/fit(895 passed), ruff, ty.