Repository navigation
tls: fix abort on negative zero sessionTimeout - #67661
Open
JuHyeong424 wants to merge 1 commit into
Open
JuHyeong424 wants to merge 1 commit into
JuHyeong424 wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
validateInt32() accepts -0, but the binding asserts IsInt32(), which V8 reports as false for -0, so the process aborts. Coerce the value to +0 before passing it to setSessionTimeout(). Signed-off-by: JuHyeong424 <wkdwngud963@gmail.com>
JuHyeong424
force-pushed
the
tls-negative-zero
branch
from
November 20, 2026 16:11
caf22f0 to
2ae6a54
Compare
Ethan-Arrowood
approved these changes
Nov 20, 2026
Ethan-Arrowood
left a comment
Contributor
There was a problem hiding this comment.
lgtm; agree this is similar to the other recently merged #65888
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67661 +/- ##
==========================================
- Coverage 90.61% 90.60% -0.01%
==========================================
Files 801 801
Lines 280966 280967 +1
Branches 54233 54224 -9
==========================================
- Hits 254592 254581 -11
- Misses 16566 16574 +8
- Partials 9808 9812 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateInt32() accepts -0, but the binding asserts IsInt32(), which V8 reports as false for -0, so the process aborts. Coerce the value to +0 before passing it to setSessionTimeout().
Reproduction
On v26.13.1:
The abort cannot be caught with try/catch.
Same class of fix as #65888 (fs) and #67651 (os).
Added
test/parallel/test-tls-negative-zero.js.