Repository navigation
Add SiteConfigStatus (interfaces#27) - #28
skunal3318 wants to merge 5 commits into
Conversation
panthera-momagdii
left a comment
There was a problem hiding this comment.
Reviewed 1f46b295ccfc99901072a263769c97adf87e18c5 against 87ab8a936c97ab55ee74b8988ca3d7659160ea6a.
The interface change is sound: SiteConfigStatus is registered, the added field bumps NavigationStatus to contract version 2, the compatibility snapshot is regenerated, and the installed C++ and DDS consumer checks exercise the nested field. The state/coverage distinction and the separate required/optional coverage reasons agree with the latest clarification on #27.
The Jazzy verification job passes. Its existing deliberate-revert check is retained; that particular fixture removes thresholds_id, so it should not be described as a site_config-specific revert run.
Source approval only: the DCO check is still action_required because this commit lacks the author's sign-off. Please correct that with your own identity before merge and let the checks rerun. This approval does not waive DCO or establish completion of N2.
I am reviewing platform-sw#73 separately. Its producer must honor these content-hash definitions and missing-input rules; the producer's current limitations are not accepted by this interface approval.
ChatGPT-assisted source and hosted-evidence review. No local ROS or simulation run.
panthera-momagdii
left a comment
There was a problem hiding this comment.
CHANGES_REQUESTED — exact head fbb7b3f93a2024b4d48a2d02f1e531da17b8f8e9, six commits after my prior source-only review of 1f46b295. The earlier SiteConfigStatus contract review is not being repeated; the new delta introduces MapIdentity.msg for the proposed #34 loader/observer contract.
[P1, current-head CI reproduction] ros2/openamr_nav_msgs/CMakeLists.txt now generates msg/MapIdentity.msg, but compatibility/jazzy.json was not regenerated for that new interface. The exact-head ROS 2 Jazzy run 42384588332 reports PASS: openamr_nav_msgs/msg/MapIdentity, PASS: 15 generated interfaces available, then FAIL: checked-in snapshot differs from generated interfaces; regenerate it for review and FAIL: interface-compatibility (exit 1). The exact-head repository-quality run 42384588660 likewise fails its delegated quality/test at the snapshot check (the separate repository-quality lint/governance job passes). Please regenerate/check in the compatibility snapshot using the repository's existing verification tooling, rerun both workflows, and keep the version/consumer compatibility checks intact.
Contract/integration gate: #34 is still Proposed, and #73's loader-to-status consumer chain is not yet integrated. Please secure the owner acceptance of the MapIdentity fields/semantics and verify the linked producer/observer on the accepted head before claiming N2 readiness. This does not retract the previously reviewed SiteConfigStatus design.
Verification: Inspected the six-commit delta, full new MapIdentity.msg, CMake registration, relevant contract/rules, earlier review, issue #34 and exact-head hosted CI job logs. NOT RUN independently: ROS 2 builds, DDS exchange, Nav2, Gazebo or hardware. No merge or safety acceptance.
Signed-off-by: Kunal Yadav <kunal780954@gmail.com>
openAMRobot#34) Signed-off-by: Kunal Yadav <kunal780954@gmail.com>
…-status # Conflicts: # compatibility/jazzy.json # ros2/openamr_nav_msgs/msg/NavigationStatus.msg
fbb7b3f to
dc5094a
Compare
Closes #27.
Adds
SiteConfigStatus, bumpsCONTRACT_VERSION1->2, updatesCONTRACT.md's versioning note and field-validity table, and extends the consumer tests (consumer.cpp,navigation_exchange.py) to exercise the new field.Verified with
tools/verify.shend-to-end: build, lint/schema, generated-interface checks, compatibility snapshot regen (compatibility/jazzy.json), clean consumer build, and the dual-RMW navigation-message-exchange test including the deliberate-revert rejection check — all PASS.