Repository navigation
Conversation
A group keyed only on the repository and item number let a pull request synchronize or an issue or pull request edit cancel an in-flight /review or /automerge comment run. Key comment runs by event name and comment id, and keep bot label events in their own group. Cancel in progress stays on for edited, synchronize, and ready_for_review. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Separate ClawSweeper comment commands, metadata events, and ignored bot labels into independent concurrency groups while preserving supersession within a comment or item event stream. Add 11 regression tests and read-only CI, document the scheduling behavior, and update the GitHub App token action to v3.3.0 with patched HTTP dependencies. Co-authored-by: Sebastien Tardif <sebtardif@ncf.ca>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR separates comment and metadata scheduling, isolates ignored bot labels, adds regression coverage and CI, and updates the pinned token action. Example: A review comment on fork pull request 1 overlaps with pull request body edits.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this PR fixes a concurrency collision still present on main, with hosted scheduling evidence and no actionable correctness or security findings. Priority: P2 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe GitHub Actions dispatcher receives issue, pull request, and comment events, schedules and filters them, then forwards eligible events to ClawSweeper. flowchart LR
A[Item events] --> C[Workflow concurrency]
B[Comment events] --> C
C --> D[Event filtering]
D --> E[Scoped app tokens]
E --> F[ClawSweeper dispatch]
Technical reviewBest possible solution: Land the scheduler separation while preserving existing dispatch payloads, credential scopes, and same-stream supersession. Do we have a high-confidence way to reproduce the issue? Current-main source assigns comment and metadata events for the same item to one group and enables cancellation for edits, establishing the reported cancellation path without executing target code. Is this the best way to solve the issue? Changing the scheduling identity at the workflow owner addresses the collision directly; the added tests inspect the actual workflow expressions and cover the relevant separation and supersession cases. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against adca46792e86. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Likely related people:
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 15, 2026, 7:22 PM ET / 23:22 UTC. |
Problem and behavior
ClawSweeper comments and item edits shared one GitHub Actions concurrency group. An overlapping edit could cancel an explicit review command; ignored bot-label runs could also displace useful work before the job filter ran.
Group runs by event type and comment identity, and isolate ignored bot labels. Edits to the same comment and superseding item metadata still cancel older runs as before. Adds 11 regression tests and a minimal, read-only pull-request/push CI workflow. Updates the pinned GitHub App token action from v3.2.0 to v3.3.0, which includes patched HTTP dependencies.
Validation
node --test --test-concurrency=2 tests/*.test.mjsactionlint -shellcheck= .github/workflows/*.ymlOriginal concurrency fix by @SebTardif; maintainer completion adds tests, documentation, the changelog, and the action update.
Carries forward #2 on a maintainer-owned branch because the fork preview is blocked on external deployment authorization. Both original commits and contributor credit are preserved; no deployment authorization or repository security setting was changed. Supersedes #2 when merged.