Skip to content

fix: keep comment commands out of the item concurrency group - #2

Merged
steipete merged 2 commits into
openclaw:mainfrom
SebTardif:fix/clawsweeper-bot-f001
Oct 15, 2026
Merged

steipete merged 2 commits into
openclaw:mainfrom
SebTardif:fix/clawsweeper-bot-f001

Conversation

@SebTardif

@SebTardif SebTardif commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Problem and behavior

ClawSweeper comments and item edits shared one GitHub Actions concurrency group. An overlapping edit could cancel an explicit review command; ignored bot-label runs could also displace useful work before the job filter ran.

Group runs by event type and comment identity, and isolate ignored bot labels. Edits to the same comment and superseding item metadata still cancel older runs as before. Adds 11 regression tests and a minimal, read-only pull-request/push CI workflow. Updates the pinned GitHub App token action from v3.2.0 to v3.3.0, which includes patched HTTP dependencies.

Validation

  • The original workflow fails five new regression cases; the fixed workflow passes all 11.
  • node --test --test-concurrency=2 tests/*.test.mjs
  • actionlint -shellcheck= .github/workflows/*.yml
  • Independent Codex P0–P2 review before landing.
  • Existing hosted scheduler proof at the contributor's original head: comment succeeded, first edit cancelled, second edit cancelled, last edit succeeded. This demonstrates scheduling, not credential-dependent downstream dispatch.

Original concurrency fix by @SebTardif; maintainer completion adds tests, documentation, the changelog, and the action update.

A group keyed only on the repository and item number let a pull request
synchronize or an issue or pull request edit cancel an in-flight
/review or /automerge comment run. Key comment runs by event name and
comment id, and keep bot label events in their own group. Cancel in
progress stays on for edited, synchronize, and ready_for_review.

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
@clawsweeper

clawsweeper Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@vercel

vercel Bot commented Oct 4, 2026

Copy link
Copy Markdown

@SebTardif is attempting to deploy a commit to the OpenClaw Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Oct 4, 2026
@clawsweeper

clawsweeper Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

This PR separates comment runs and ignored bot-label events from item-update concurrency groups.

Example: A review comment on fork pull request 1 is followed by overlapping body edits.

  • Before: An edit can cancel the comment workflow because both use the same item concurrency group.
  • After: Comment run 37850978898 succeeds while earlier item-update runs are cancelled and the last edit succeeds.

Review scores

Measure Result What it means
Overall readiness 🦞 diamond lobster (5/6) A focused, useful scheduler repair with verified hosted behavior and no actionable correctness or security findings.
Proof confidence 🦞 diamond lobster (5/6) ✨ media proof bonus Sufficient (linked_artifact): The changed GitHub Actions concurrency owner was exercised on GitHub-hosted runners using the reviewed head: the comment workflow survived overlapping item updates while earlier update runs were cancelled. The contributor explicitly excludes credential-dependent downstream dispatch, which this patch does not change.
Patch quality 🦞 diamond lobster (5/6) No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Complete
User problem: A requested review or automerge comment can lose its dispatcher run when the item is edited or synchronized.
Reason: Independent comment commands should survive unrelated item updates, and the patch repairs that behavior with one focused change.

Merge readiness

✅ Ready for maintainer review

This PR fixes a concurrency collision still present on current main; the hosted evidence supports the scheduler change, and no introduced defect was found.

Priority: P2
Reviewed head: 46a12f4cea9890971012bed37a53dd5f3340880e

Before merge

None.

Findings

None.

Agent review details

How this fits together

The GitHub Actions dispatcher receives issue, pull request, and comment events, applies scheduling and filtering, and forwards eligible events to ClawSweeper.

flowchart LR
  A[GitHub item events] --> C[Workflow concurrency]
  B[GitHub comment events] --> C
  C --> D[Event filtering]
  D --> E[Dispatch credentials]
  E --> F[ClawSweeper event dispatch]
Loading

Technical review

Best possible solution:

Keep the focused scheduler fix so item updates cannot cancel independent comment commands.

Do we have a high-confidence way to reproduce the issue?

Current-main source assigns comments and edits on the same item to one group and enables cancellation for edits, establishing the cancellation path without running target code.

Is this the best way to solve the issue?

Separating scheduling identities at the workflow owner addresses the collision directly while retaining item-update supersession and existing dispatch behavior.

AGENTS.md: not found in the target repository.

Codex review notes: model internal, reasoning medium; reviewed against adca46792e86.

Provenance checked

  • Workflow concurrency grouping changes intended behavior with a stated reason (adca467: The workflow was added to dispatch ClawSweeper events. Commit inspection and the commit-to-PR lookup found no separate rationale requiring comments and item updates to cancel each other.)

Testing

Proof path: shipped entry point.

Security

None.

Evidence

What I checked:

Labels

Label changes:

No label changes.

Label justifications:

  • P2: The existing workflow can cancel a requested command during item updates; the focused fix has limited scope.
  • rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.
  • proof: sufficient: Contributor real behavior proof is sufficient.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (64 earlier review cycles; latest 8 shown)
  • reviewed 2026-10-13T19:59:25.554Z sha 46a12f4 :: needs maintainer review before merge. :: none
  • reviewed 2026-10-13T21:43:42.631Z sha 46a12f4 :: needs maintainer review before merge. :: none
  • reviewed 2026-10-14T02:01:00.676Z sha 46a12f4 :: needs maintainer review before merge. :: none
  • reviewed 2026-10-14T05:26:46.881Z sha 46a12f4 :: needs maintainer review before merge. :: none
  • reviewed 2026-10-14T07:34:28.557Z sha 46a12f4 :: needs maintainer review before merge. :: none
  • reviewed 2026-10-14T08:52:12.252Z sha 46a12f4 :: needs maintainer review before merge. :: none
  • reviewed 2026-10-14T10:28:09.600Z sha 46a12f4 :: needs maintainer review before merge. :: none
  • reviewed 2026-10-14T11:58:23.385Z sha 46a12f4 :: needs maintainer review before merge. :: none

Reviewed October 14, 2026, 10:23 AM ET / 14:23 UTC (Revision 65).

@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Oct 8, 2026
@SebTardif

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

The body now has hosted runs. A comment dispatch succeeded while two overlapping edits cancelled each other.

@clawsweeper

clawsweeper Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. and removed status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. labels Oct 8, 2026
@clawsweeper clawsweeper Bot added the status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. label Oct 11, 2026
Separate ClawSweeper comment commands, metadata events, and ignored bot labels into independent concurrency groups while preserving supersession within a comment or item event stream.

Add 11 regression tests and read-only CI, document the scheduling behavior, and update the GitHub App token action to v3.3.0 with patched HTTP dependencies.

Co-authored-by: Sebastien Tardif <sebtardif@ncf.ca>

@steipete steipete left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the concurrency fix and maintainer completion. Five regression cases fail against the previous workflow, and all 11 pass with this change locally and on Linux. Independent Codex P0–P2 review is clean. The same reviewed head also has successful tests, security analysis, and a Vercel preview through #3.

@steipete
steipete merged commit 13419ce into openclaw:main Oct 15, 2026
11 of 13 checks passed
@steipete

steipete commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Merged through this original PR, with contributor credit preserved. Thanks @SebTardif.

The original workflow failed five concurrency regression cases. All 11 cases now pass locally and on Linux, and independent Codex review found no actionable P0–P2 issues. The reviewed PR head passed CI, security analysis, and Vercel preview checks. The cancelled legacy dispatch check passed on one retry.

Temporary maintainer PR #3 supplied the preview for the identical head without changing deployment authorization or repository security settings, and is now closed. The final change also updates the GitHub App token action to v3.3.0.

This branch was successfully deployed

1 active deployment
Preview — 56335aa0 Deployed Oct 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. proof: sufficient Contributor real behavior proof is sufficient. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants