Repository navigation
fix: keep comment commands out of the item concurrency group - #2
Conversation
A group keyed only on the repository and item number let a pull request synchronize or an issue or pull request edit cancel an in-flight /review or /automerge comment run. Key comment runs by event name and comment id, and keep bot label events in their own group. Cancel in progress stays on for edited, synchronize, and ready_for_review. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
@SebTardif is attempting to deploy a commit to the OpenClaw Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
Codex review: needs maintainer review before merge. What this changesThis PR separates comment runs and ignored bot-label events from item-update concurrency groups. Example: A review comment on fork pull request 1 is followed by overlapping body edits.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review This PR fixes a concurrency collision still present on current main; the hosted evidence supports the scheduler change, and no introduced defect was found. Priority: P2 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe GitHub Actions dispatcher receives issue, pull request, and comment events, applies scheduling and filtering, and forwards eligible events to ClawSweeper. flowchart LR
A[GitHub item events] --> C[Workflow concurrency]
B[GitHub comment events] --> C
C --> D[Event filtering]
D --> E[Dispatch credentials]
E --> F[ClawSweeper event dispatch]
Technical reviewBest possible solution: Keep the focused scheduler fix so item updates cannot cancel independent comment commands. Do we have a high-confidence way to reproduce the issue? Current-main source assigns comments and edits on the same item to one group and enables cancellation for edits, establishing the cancellation path without running target code. Is this the best way to solve the issue? Separating scheduling identities at the workflow owner addresses the collision directly while retaining item-update supersession and existing dispatch behavior. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against adca46792e86. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
LabelsLabel changes: No label changes. Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (64 earlier review cycles; latest 8 shown)
Reviewed October 14, 2026, 10:23 AM ET / 14:23 UTC (Revision 65). |
|
@clawsweeper re-review The body now has hosted runs. A comment dispatch succeeded while two overlapping edits cancelled each other. |
|
🦞👀 Re-review progress:
|
Separate ClawSweeper comment commands, metadata events, and ignored bot labels into independent concurrency groups while preserving supersession within a comment or item event stream. Add 11 regression tests and read-only CI, document the scheduling behavior, and update the GitHub App token action to v3.3.0 with patched HTTP dependencies. Co-authored-by: Sebastien Tardif <sebtardif@ncf.ca>
steipete
left a comment
There was a problem hiding this comment.
Reviewed the concurrency fix and maintainer completion. Five regression cases fail against the previous workflow, and all 11 pass with this change locally and on Linux. Independent Codex P0–P2 review is clean. The same reviewed head also has successful tests, security analysis, and a Vercel preview through #3.
|
Merged through this original PR, with contributor credit preserved. Thanks @SebTardif. The original workflow failed five concurrency regression cases. All 11 cases now pass locally and on Linux, and independent Codex review found no actionable P0–P2 issues. The reviewed PR head passed CI, security analysis, and Vercel preview checks. The cancelled legacy dispatch check passed on one retry. Temporary maintainer PR #3 supplied the preview for the identical head without changing deployment authorization or repository security settings, and is now closed. The final change also updates the GitHub App token action to v3.3.0. |
Problem and behavior
ClawSweeper comments and item edits shared one GitHub Actions concurrency group. An overlapping edit could cancel an explicit review command; ignored bot-label runs could also displace useful work before the job filter ran.
Group runs by event type and comment identity, and isolate ignored bot labels. Edits to the same comment and superseding item metadata still cancel older runs as before. Adds 11 regression tests and a minimal, read-only pull-request/push CI workflow. Updates the pinned GitHub App token action from v3.2.0 to v3.3.0, which includes patched HTTP dependencies.
Validation
node --test --test-concurrency=2 tests/*.test.mjsactionlint -shellcheck= .github/workflows/*.ymlOriginal concurrency fix by @SebTardif; maintainer completion adds tests, documentation, the changelog, and the action update.