Skip to content

Fix proto2 extension field handling. - #77

Merged
psobot merged 3 commits into
masterfrom
psobot/pr68-extension-fields
Aug 8, 2026
Merged

psobot merged 3 commits into
masterfrom
psobot/pr68-extension-fields

Conversation

@psobot

@psobot psobot commented Aug 8, 2026 •

Copy link
Copy Markdown
Owner

Closes #68.

Florian Kruse and others added 3 commits March 5, 2026 21:11
Resolves the README conflict against the dumper documentation rewritten in
#73, and reformats one line to satisfy the ruff-format hook added in #76.

The README resolution is not simply one side or the other. #73 documented the
extraction step as requiring a codesigning identity in Keychain Access, which
this PR makes untrue - it now falls back to ad-hoc signing. It also documented
running the step via `uv run --script`, which cannot work: extract_mapping.py
locates LLDB's Python bindings by matching the running interpreter's version
against the installed LLVM, so uv's bundled Python never finds them. Both facts
come from this PR and are folded in.

The two constraints on that step are now stated together, since they interact:
it needs Homebrew's Python (for LLDB) *and* protobuf<4 (for protodump). The
`brew install protobuf` prerequisite is dropped - protoc has been pinned and
downloaded automatically since #73.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0179M4xvAKPGrgKpy4AeCsM7
@psobot psobot changed the title Fix proto2 extension field handling (takes over #68) Fix proto2 extension field handling. Aug 8, 2026
@psobot
psobot merged commit 8d7a266 into master Aug 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant