Repository navigation
Deprecate ReplaceArgumentDefaultValueRector in favor of custom rule - #8686
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
tv-deprecate-replace-argument-default-value
branch
from
October 17, 2026 18:23
3bd13dc to
4dc7f9d
Compare
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
ReplaceArgumentDefaultValueRector.Its configuration is weak and messy - it relies on magic strings to reference constants (e.g.
'SomeClass::OLD_CONSTANT'), with no type safety and no IDE support. A dedicated custom Rector rule is a clearer and safer way to replace arguments.DeprecatedInterface+@deprecatedrefactor()now throws, body/config strippedNote: the rule is
@api used in rector-symfony, so a follow-up PR there is needed to drop its usage.