[rtlopez]

code tidy - no functional change expected

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6eca1815-0766-4999-ac9e-0671a1ca601e

📥 Commits

Reviewing files that changed from the base of the PR and between 2420903 and 09daf2a.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: ae3d42a9-f5c1-4adc-b9f3-9f3319331ca6

📥 Commits

Reviewing files that changed from the base of the PR and between 07cb360 and 2420903.

📒 Files selected for processing: 25

• lib/EscDriver/src/EscDriver.h
• lib/EscDriver/src/EscDriver.hpp
• lib/EscDriver/src/EscDriverBase.cpp
• lib/EscDriver/src/EscDriverBase.hpp
• lib/EscDriver/src/EscDriverEsp32.cpp
• lib/EscDriver/src/EscDriverEsp32.h
• lib/EscDriver/src/EscDriverEsp32.hpp
• lib/EscDriver/src/EscDriverEsp32c3.cpp
• lib/EscDriver/src/EscDriverEsp32c3.h
• lib/EscDriver/src/EscDriverEsp32c3.hpp
• lib/EscDriver/src/EscDriverEsp8266.cpp
• lib/EscDriver/src/EscDriverEsp8266.h
• lib/EscDriver/src/EscDriverEsp8266.hpp
• lib/EscDriver/src/EscDriverRP2040.cpp
• lib/EscDriver/src/EscDriverRP2040.h
• lib/EscDriver/src/EscDriverRP2040.hpp
• lib/Espfc/src/Model.h
• lib/Espfc/src/ModelConfig.h
• lib/Espfc/src/Output/Mixer.h
• lib/betaflight/src/platform_cpp.cpp
• platformio.ini
• test/test_esc/test_esc.cpp
• test/test_math/test_math.cpp
• test/test_msp/test_msp.cpp
• test/test_storage/test_storage.cpp

💤 Files with no reviewable changes: 5

• lib/EscDriver/src/EscDriver.h
• lib/EscDriver/src/EscDriverEsp8266.h
• lib/EscDriver/src/EscDriverEsp32c3.h
• lib/EscDriver/src/EscDriverRP2040.h
• lib/EscDriver/src/EscDriverEsp32.h

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The change moves ESC driver selection and platform declarations from .h files to .hpp files and updates their include sites. ESP32, ESP32-C3, ESP8266, and RP2040 implementations receive platform API and fast-code annotation updates. The described protocol, timing, pulse-conversion, and telemetry logic remains unchanged except for the specified API substitutions and channel-check changes.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 24209

No specific failure has been established that would block merging. The ESP32-C3 build remains unverified and should receive the normal platform build check.

Pre-merge checks: 3 · 1 · 1

Failed checks: 1 warning · 1 inconclusive

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 6.36% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 110 functions across 19 files. (1 skipped:…	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check		The title identifies the EscDriver area but uses the vague phrase "code tidy". It does not describe the main changes, such as the header migration and platform API updates.	Use a specific title, such as "Migrate EscDriver headers and platform implementations to C++ and HAL APIs".

Passed checks: 3 passed

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.

Full details: Docstring Coverage

Explanation

Docstring coverage is 6.36% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 110 functions across 19 files. (1 skipped: 1 unsupported.)

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}