release/2.18.0 -> develop by chainchad · Pull Request #15076 · smartcontractkit/chainlink

chainchad · 2024-11-01T18:07:41Z

Fixes merge conflicts by merging develop into this HEAD branch which was branched from release/2.18.0.

Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com>

…r from TypeAndVersion (#14861) * core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion * .github: CCIP CODEOWNERS (cherry picked from commit cc9bafa)

…18.0 core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion [2.18.0]

…n finalized block (#14914) (cherry picked from commit 47aaff4)

…ent-confirmer-false-warning-2.18-cerry-pick Hotfix/BCFR 1065 prevent confirmer false warning 2.18

* Update DA oracle config struct members to pointers * Update tests and remake config docs * suggestions and fix docs_test * fix config test (cherry picked from commit b585654)

…bugfix-da-struct Update DA oracle config struct members to pointers (#15008)

Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com>

github-actions · 2024-11-01T18:15:57Z

Static analysis results are available

Hey @chainchad, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

github-actions · 2024-11-01T19:07:53Z

AER Report: CI Core

1. Integer overflow conversion error:golangci-lint

Source of Error:

<error column="17" line="126" message="G115: integer overflow conversion int -> uint32" severity="high" source="gosec"></error>
<error column="17" line="132" message="G115: integer overflow conversion int64 -> uint32" severity="high" source="gosec"></error>
<error column="17" line="138" message="G115: integer overflow conversion uint -> uint32" severity="high" source="gosec"></error>
<error column="28" line="293" message="G115: integer overflow conversion int64 -> int32" severity="high" source="gosec"></error>
<error column="28" line="304" message="G115: integer overflow conversion int64 -> int32" severity="high" source="gosec"></error>
<error column="60" line="154" message="G115: integer overflow conversion int -> int32" severity="high" source="gosec"></error>
<error column="22" line="39" message="G115: integer overflow conversion int -> uint8" severity="high" source="gosec"></error>
<error column="14" line="251" message="G115: integer overflow conversion int64 -> int32" severity="high" source="gosec"></error>
<error column="41" line="167" message="G115: integer overflow conversion uint64 -> int64" severity="high" source="gosec"></error>
<error column="21" line="66" message="G115: integer overflow conversion uint64 -> uint32" severity="high" source="gosec"></error>
<error column="39" line="137" message="G115: integer overflow conversion int64 -> uint64" severity="high" source="gosec"></error>
<error column="30" line="50" message="G115: integer overflow conversion int64 -> uint64" severity="high" source="gosec"></error>
<error column="105" line="37" message="non-wrapping format verb for fmt.Errorf. Use `%w` to format errors" severity="error" source="errorlint"></error>
<error column="105" line="44" message="non-wrapping format verb for fmt.Errorf. Use `%w` to format errors" severity="error" source="errorlint"></error>
<error column="25" line="334" message="G115: integer overflow conversion uint -> int" severity="high" source="gosec"></error>
<error column="38" line="331" message="G115: integer overflow conversion uint -> int" severity="high" source="gosec"></error>
<error column="18" line="344" message="G115: integer overflow conversion uint -> int" severity="high" source="gosec"></error>
<error column="29" line="58" message="G115: integer overflow conversion uint -> int64" severity="high" source="gosec"></error>
<error column="21" line="109" message="G115: integer overflow conversion int64 -> uint32" severity="high" source="gosec"></error>
<error column="81" line="115" message="directive `//nolint:gosec` is unused for linter \"gosec\"" severity="error" source="nolintlint"></error>
<error column="23" line="160" message="directive `//nolint:gosec // G115` is unused for linter \"gosec\"" severity="error" source="nolintlint"></error>
<error column="17" line="63" message="appendAssign: append result not assigned to the same slice" severity="error" source="gocritic"></error>
<error column="20" line="83" message="G115: integer overflow conversion int -> uint64" severity="high" source="gosec"></error>
<error column="40" line="241" message="G602: slice index out of range" severity="low" source="gosec"></error>
<error column="9" line="257" message="G602: slice index out of range" severity="low" source="gosec"></error>
<error column="9" line="260" message="G602: slice index out of range" severity="low" source="gosec"></error>
<error column="10" line="686" message="G115: integer overflow conversion int -> uint64" severity="high" source="gosec"></error>
<error column="22" line="393" message="G115: integer overflow conversion int64 -> uint64" severity="high" source="gosec"></error>
<error column="17" line="188" message="appendAssign: append result not assigned to the same slice" severity="error" source="gocritic"></error>
<error column="17" line="199" message="appendAssign: append result not assigned to the same slice" severity="error" source="gocritic"></error>
<error column="6" line="110" message="directive `//nolint:errcheck` should provide explanation such as `//nolint:errcheck // this is why`" severity="error" source="nolintlint"></error>
<error column="52" line="28" message="directive `//nolint:gosimple` should provide explanation such as `//nolint:gosimple // this is why`" severity="error" source="nolintlint"></error>
<error column="6" line="25" message="the type name `ErrOverride` should conform to the `XxxError` format" severity="error" source="errname"></error>
<error column="6" line="33" message="the type name `ErrDeprecated` should conform to the `XxxError` format" severity="error" source="errname"></error>
<error column="27" line="30" message="G115: integer overflow conversion uint -> int64" severity="high" source="gosec"></error>
<error column="66" line="151" message="G115: integer overflow conversion int64 -> uint32" severity="high" source="gosec"></error>
<error column="57" line="55" message="non-wrapping format verb for fmt.Errorf. Use `%w` to format errors" severity="error" source="errorlint"></error>
<error column="15" line="58" message="fmt.Errorf can be replaced with errors.New" severity="error" source="perfsprint"></error>
<error column="2" line="18" message="negative-positive: use require.Positive" severity="error" source="testifylint"></error>
<error column="2" line="73" message="error-nil: use require.NoError" severity="error" source="testifylint"></error>
<error column="2" line="80" message="float-compare: use require.InEpsilon (or InDelta)" severity="error" source="testifylint"></error>
<error column="2" line="88" message="float-compare: use require.InEpsilon (or InDelta)" severity="error" source="testifylint"></error>
<error column="2" line="30" message="error-nil: use require.NoError" severity="error" source="testifylint"></error>
<error column="18" line="53" message="dupArg: suspicious method call with the same argument and receiver" severity="error" source="gocritic"></error>
<error column="7" line="41" message="captLocal: `P' should not be capitalized" severity="error" source="gocritic"></error>
<error column="7" line="46" message="captLocal: `P' should not be capitalized" severity="error" source="gocritic"></error>
<error column="7" line="52" message="captLocal: `P' should not be capitalized" severity="error" source="gocritic"></error>
<error column="9" line="259" message="elseif: can replace 'else {if cond {}}' with 'else if cond {}'" severity="error" source="gocritic"></error>
<error column="40" line="241" message="G602: slice index out of range" severity="low" source="gosec"></error>
<error column="9" line="257" message="G602: slice index out of range" severity="low" source="gosec"></error>
<error column="9" line="260" message="G602: slice index out of range" severity="low" source="gosec"></error>
<error column="2" line="244" message="Consider pre-allocating `csaIDs`" severity="error" source="prealloc"></error>
<error column="2" line="248" message="Consider pre-allocating `ethIDs`" severity="error" source="prealloc"></error>
<error column="2" line="252" message="Consider pre-allocating `ocrIDs`" severity="error" source="prealloc"></error>
<error column="2" line="256" message="Consider pre-allocating `ocr2IDs`" severity="error" source="prealloc"></error>
<error column="2" line="260" message="Consider pre-allocating `p2pIDs`" severity="error" source="prealloc"></error>
<error column="2" line="264" message="Consider pre-allocating `cosmosIDs`" severity="error" source="prealloc"></error>
<error column="2" line="268" message="Consider pre-allocating `solanaIDs`" severity="error" source="prealloc"></error>
<error column="2" line="272" message="Consider pre-allocating `starknetIDs`" severity="error" source="prealloc"></error>
<error column="2" line="276" message="Consider pre-allocating `aptosIDs`" severity="error" source="prealloc"></error>
<error column="2" line="280" message="Consider pre-allocating `vrfIDs`" severity="error" source="prealloc"></error>
<error column="2" line="32" message="Consider pre-allocating `ocr2`" severity="error" source="prealloc"></error>
<error column="2" line="33" message="Consider pre-allocating `ocr2_raw`" severity="error" source="prealloc"></error>
<error column="6" line="42" message="the type name `ErrObservationFailed` should conform to the `XxxError` format" severity="error" source="errname"></error>
<error column="2" line="105" message="Consider pre-allocating `rs`" severity="error" source="prealloc"></error>
<error column="2" line="106" message="Consider pre-allocating `ss`" severity="error" source="prealloc"></error>
<error column="24" line="171" message="unnecessary conversion" severity="error" source="unconvert"></error>
<error column="23" line="172" message="unnecessary conversion" severity="error" source="unconvert"></error>
<error column="30" line="161" message="directive `// nolint` should be written without leading space as `//nolint`" severity="error" source="nolintlint"></error>
<error column="30" line="162" message="directive `// nolint` should be written without leading space as `//nolint`" severity="error" source="nolintlint"></error>
<error column="38" line="75" message="directive `//nolint` should mention specific linter such as `//nolint:my-linter`" severity="error" source="nolintlint"></error>
<error column="50" line="165" message="directive `//nolint` should mention specific linter such as `//nolint:my-linter`" severity="error" source="nolintlint"></error>
<error column="3" line="62" message="empty: use require.Empty" severity="error" source="testifylint"></error>
<error column="3" line="87" message="empty: use require.Empty" severity="error" source="testifylint"></error>
<error column="37" line="78" message="fmt.Sprintf can be replaced with faster strconv.FormatUint" severity="error" source="perfsprint"></error>
<error column="14" line="82" message="fmt.Sprintf can be replaced with faster strconv.FormatUint" severity="error" source="perfsprint"></error>
<error column="92" line="125" message="fmt.Sprintf can be replaced with faster hex.EncodeToString" severity="error" source="perfsprint"></error>
<error column="63" line="203" message="fmt.Sprintf can be replaced with faster strconv.Itoa" severity="error" source="perfsprint"></error>
<error column="41" line="167" message="fmt.Sprintf can be replaced with faster strconv.FormatUint" severity="error" source="perfsprint"></error>
<error column="33" line="157" message="unnecessary conversion" severity="error" source="unconvert"></error>
<error column="4" line="473" message="nested context in loop" severity="error" source="fatcontext"></error>
<error column="2" line="396" message="missing cases in switch of type chaintype.ChainType: chaintype.ChainMantle" severity="error" source="exhaustive"></error>
<error column="2" line="212" message="directive `//nolint sqlclosecheck false positive` should match `//nolint sqlclosecheck false positive[:<comma-separated-linters>] [// <explanation>]`" severity="error" source="nolintlint"></error>
<error column="65" line="281" message="directive `//nolint sqlclosecheck false positive` should match `//nolint sqlclosecheck false positive[:<comma-separated-linters>] [// <explanation>]`" severity="error" source="nolintlint"></error>
<error column="6" line="82" message="the type name `ErrJobSpecNoRelayer` should conform to the `XxxError` format" severity="error" source="errname"></error>
<error column="6" line="93" message="the type name `ErrRelayNotEnabled` should conform to the `XxxError` format" severity="error" source="errname"></error>
<error column="9" line="19" message="fmt.Sprintf can be replaced with string concatenation" severity="error" source="perfsprint"></error>
<error column="35" line="61" message="directive `//nolint:containedctx` should provide explanation such as `//nolint:containedctx // this is why`" severity="error" source="nolintlint"></error>
<error column="35" line="72" message="directive `//nolint:containedctx` should provide explanation such as `//nolint:containedctx // this is why`" severity="error" source="nolintlint"></error>
<error column="3" line="1334" message="assignOp: replace `closestBlockNum = closestBlockNum - blockOffset` with `closestBlockNum -= blockOffset`" severity="error" source="gocritic"></error>
<error column="2" line="95" message="captLocal: `GasPriceHeartBeat' should not be capitalized" severity="error" source="gocritic"></error>
<error column="2" line="96" message="captLocal: `DAGasPriceDeviationPPB' should not be capitalized" severity="error" source="gocritic"></error>
<error column="2" line="97" message="captLocal: `ExecGasPriceDeviationPPB' should not be capitalized" severity="error" source="gocritic"></error>
<error column="25" line="29" message="directive `//nolint:staticcheck` should provide explanation such as `//nolint:staticcheck // this is why`" severity="error" source="nolintlint"></error>
<error column="25" line="28" message="directive `//nolint:staticcheck` should provide explanation such as `//nolint:staticcheck // this is why`" severity="error" source="nolintlint"></error>
<error column="35" line="45" message="directive `//nolint:containedctx` should provide explanation such as `//nolint:containedctx // this is why`" severity="error" source="nolintlint"></error>
<error column="9" line="93" message="elseif: can replace 'else {if cond {}}' with 'else if cond {}'" severity="error" source="gocritic"></error>
<error column="19" line="109" message="fmt.Sprintf can be replaced with string concatenation" severity="error" source="perfsprint"></error>
<error column="21" line="500" message="shadow: declaration of \"err\" shadows declaration at line 459" severity="error" source="govet"></error>
<error column="2" line="79" message="ifElseChain: rewrite if-else to switch statement" severity="error" source="gocritic"></error>
<error column="19" line="48" message="fmt.Sprintf can be replaced with string concatenation" severity="error" source="perfsprint"></error>
<error column="90" line="135" message="underef: could simplify (*mc.LinkFeedID).String to mc.LinkFeedID.String" severity="error" source="gocritic"></error>
<error column="90" line="136" message="underef: could simplify (*mc.NativeFeedID).String to mc.NativeFeedID.String" severity="error" source="gocritic"></error>
<error column="5" line="13" message="var-naming: var v1FeedId should be v1FeedID" severity="warning" source="revive"></error>
<error column="5" line="14" message="var-naming: var v2FeedId should be v2FeedID" severity="warning" source="revive"></error>
<error column="33" line="49" message="G115: integer overflow conversion uint64 -> int64" severity="high" source="gosec"></error>
<error column="4" line="98" message="error-nil: use assert.NoError" severity="error" source="testifylint"></error>
<error column="5" line="112" message="len: use
</cicore>

The base branch was changed.

chainchad and others added 10 commits October 22, 2024 14:49

Bump version and update CHANGELOG fore core v2.18.0

4527810

Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com>

core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check erro…

bbd887e

…r from TypeAndVersion (#14861) * core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion * .github: CCIP CODEOWNERS (cherry picked from commit cc9bafa)

Merge pull request #14901 from smartcontractkit/ccipdata-err-check-2.…

d21d159

…18.0 core/services/ocr2/plugins/ccip/internal/ccipdata/factory: check error from TypeAndVersion [2.18.0]

TXM Configmer logs warning only if the provided chain does not contai…

1d72e0c

…n finalized block (#14914) (cherry picked from commit 47aaff4)

Merge pull request #14938 from smartcontractkit/hotfix/BCFR-1065-prev…

571c154

…ent-confirmer-false-warning-2.18-cerry-pick Hotfix/BCFR 1065 prevent confirmer false warning 2.18

Update DA oracle config struct members to pointers (#15008)

6951f9e

* Update DA oracle config struct members to pointers * Update tests and remake config docs * suggestions and fix docs_test * fix config test (cherry picked from commit b585654)

Merge pull request #15031 from smartcontractkit/chore/release/2.18.0-…

3fffeed

…bugfix-da-struct Update DA oracle config struct members to pointers (#15008)

Consume latest changeset and update changelog (#15036)

0e85537

Finalize date on changelog for 2.18.0 (#15073)

fb7d6e8

Signed-off-by: chainchad <96362174+chainchad@users.noreply.github.com>

Merge branch 'develop' into chore/release/2.18.0-to-develop

6f2c3e8

chainchad requested review from a team, 0xsuryansh, RayXpub, RensR, RyanRHall, elatoskinas, jhweintraub, matYang and samsondav as code owners November 1, 2024 18:07

chainchad requested review from a team, eutopian and yevshev as code owners November 1, 2024 18:07

chainchad requested review from 0xnogo, Atrax1, asoliman92, dimkouv, makramkd, mateusz-sekara, rstout and winder and removed request for a team November 1, 2024 18:07

momentmaker previously approved these changes Nov 1, 2024

View reviewed changes

chainchad mentioned this pull request Nov 1, 2024

release/2.18.0 -> develop #14897

Closed

chainchad changed the title ~~chore/release/2.18.0 to develop~~ chore/release/2.18.0 to fix v2.18.0 merge conflicts Nov 1, 2024

chainchad changed the title ~~chore/release/2.18.0 to fix v2.18.0 merge conflicts~~ Fix v2.18.0 merge conflicts Nov 1, 2024

vyzaldysanchez previously approved these changes Nov 4, 2024

View reviewed changes

chainchad changed the base branch from release/2.18.0 to develop November 4, 2024 19:04

chainchad requested a review from a team as a code owner November 4, 2024 19:04

chainchad changed the title ~~Fix v2.18.0 merge conflicts~~ release/2.18.0 -> develop Nov 4, 2024

chainchad requested review from momentmaker and vyzaldysanchez November 4, 2024 19:24

chainchad closed this Nov 4, 2024

Navigation Menu

Uh oh!

release/2.18.0 -> develop - #15076

release/2.18.0 -> develop#15076
chainchad wants to merge 10 commits into
developfrom
chore/release/2.18.0-to-develop

chainchad commented Nov 1, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Nov 1, 2024

Uh oh!

github-actions Bot commented Nov 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

chainchad commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 1, 2024

Static analysis results are available

Uh oh!

github-actions Bot commented Nov 1, 2024

AER Report: CI Core

1. Integer overflow conversion error:golangci-lint

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chainchad commented Nov 1, 2024 •

edited

Loading