Conversation
hakiers
force-pushed
the
hakiers/1414-ls
branch
from
September 23, 2026 13:05
2f074cb to
53d2453
Compare
hakiers
marked this pull request as ready for review
September 23, 2026 13:32
hakiers
requested review from
Arcticae,
piotmag769 and
wawel37
and removed request for
a team
September 23, 2026 13:32
Arcticae
requested changes
Sep 24, 2026
Comment on lines
+136
to
+137
| # temporary until scarb-proc-macro-server-types 0.6.0 is published | ||
| scarb-proc-macro-server-types = { git = "https://github.com/software-mansion/scarb", rev = "5113000d732f6f92b9d2e567742eb8076cf580f6" } |
Member
There was a problem hiding this comment.
Shouldn't this be a draft until this is actually released, so we see that the checks pass and only then mark it as ready to merge?
Collaborator
There was a problem hiding this comment.
The PR can be a draft, but we should merge after merging the PR on scarb's side. The release of the package always happened on Scarb release iirc
Contributor
Author
There was a problem hiding this comment.
We can convert this to a draft. We should also update the version https://github.com/software-mansion/cairols/pull/1415/changes#diff-751af1a340658c7b8176fe32d7db9fadbe15d1d075daba1919a91df04155bc70R1 after the Scarb release.
hakiers
force-pushed
the
hakiers/1414-ls
branch
from
September 24, 2026 11:14
5cb53b3 to
d06607c
Compare
hakiers
force-pushed
the
hakiers/1414-ls
branch
from
September 24, 2026 14:23
252b120 to
2bed480
Compare
hakiers
marked this pull request as draft
September 24, 2026 14:26
Arcticae
reviewed
Sep 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: #1414
Summary
Sends the call site of every derive (already computed by
parse_derive) to the proc macro server instead of the first one only, and maps expansion results back per derive.Counterpart of software-mansion/scarb#3275; requires
scarb-proc-macro-server-types0.6.0.Note
[patch.crates-io]entries pointing at the Scarb branch are temporary until0.6.0is published; they will be removed before merge.[.tool-versions]pointing at the Scarb dev build are temporary until the new release.