Conversation
hakiers
marked this pull request as ready for review
September 23, 2026 13:32
hakiers
requested review from
Arcticae,
piotmag769 and
wawel37
and removed request for
a team
September 23, 2026 13:32
piotmag769
reviewed
Sep 23, 2026
piotmag769
approved these changes
Sep 23, 2026
hakiers
force-pushed
the
hakiers/1414-ls
branch
from
September 24, 2026 07:37
b8b3b10 to
83ab161
Compare
Arcticae
requested changes
Sep 24, 2026
Arcticae
left a comment
Member
There was a problem hiding this comment.
Please implement the regression test we talked about f2f
hakiers
force-pushed
the
hakiers/1414-ls
branch
from
September 24, 2026 13:38
d7be9bf to
a31fbf7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of software-mansion/cairols#1414
Summary
ExpandDeriveParamsnow carries a call site per derive (derives: Vec<Derive { name, call_site }>) instead of onecall_sitefor the whole batch, and the PMS expands each derive with its own call site — as the compile path already does.Why
With a single call site, everything produced by the 2nd, 3rd, … derive of
#[derive(A, B, C)]— token spans fromTextSpan::call_site(),CallSitecode mappings, diagnostics — was attributed to the first derive. E.g.Fuzzable'sDebugerror was underlined on the first derive in the attribute. The field was added in #2120 for V2 support without accounting for batched derives.Breaking change
scarb-proc-macro-server-types0.6.0:ExpandDeriveParamsshape changed. Only the PMS and cairols use it, and the LS ships with Scarb.The bundled
cairo-language-serverrev must be bumped to a commit using0.6.0before release — cairols side: software-mansion/cairols#1415.