SolidBase Reproduction - Project-specific labels#1589
Closed
birkskyum wants to merge 1 commit into
Closed
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to set the SolidStart version dropdown labels to
v1 (Latest)v2 (RC)But I hit a SolidBase limitation here. I need labels that are project (Start) specific. I'd like to not change Solid core's labels from
Latestandv2(although they could benefit from similar imrpovemnts, but it's out of scope for this PR) - I would just like to have SolidStart showv1 (Latest)andv2 (RC), to make that distinction clear.The existing
routes.version.valuesmetadata is shared by every project. I tried adding separate Start version values with the same paths, but then/solid-startno longer matches because an empty version segment only resolves to the axis default. This broke the SolidStart top-nav link.An override mechanism can also solve it.