Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Reviewed changes address the MLS read-receipt issue with regression coverage.
Pull request overview
Prevents read receipts for MLS group conversations while preserving existing behavior elsewhere.
Changes:
- Excludes MLS groups from read-confirmation eligibility.
- Adds MLS and mixed-group regression tests.
File summaries
| File | Description |
|---|---|
wire-ios-data-model/Tests/Source/Model/Messages/ZMMessageTests+Confirmation.swift |
Tests MLS suppression and mixed-group behavior. |
wire-ios-data-model/Source/Model/Message/ZMOTRMessage+Confirmations.swift |
Blocks read confirmations for MLS groups. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Test Results 7 files 988 suites 10m 36s ⏱️ For more details on these failures, see this check. Results for commit 12ef3da. ♻️ This comment has been updated with latest results. Summary: workflow run #35100584640 |
samwyndham
approved these changes
Sep 11, 2026
acv-w
approved these changes
Sep 16, 2026
netbe
enabled auto-merge (squash)
September 16, 2026 13:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Cherry-pick of #5124.
Testing
N/A
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: