fix: prevent MLS group read receipts - WPB-27764

wire-ios-data-model/Source/Model/Message/ZMOTRMessage+Confirmations.swift

@@ -68,7 +68,7 @@ extension ZMOTRMessage {
             return expectsReadConfirmation && readReceiptsEnabled
 
         } else if conversation.conversationType == .group {
-            return expectsReadConfirmation
+            return conversation.messageProtocol != .mls && expectsReadConfirmation
         }
 
         return false

wire-ios-data-model/Tests/MLS/MLSServiceTests.swift

@@ -474,6 +474,10 @@ final class MLSServiceTests: ZMConversationTestsBase, MLSServiceDelegate {
 
     func test_EstablishGroupWithMultipleUsers_IsSuccessful() async throws {
         // Given
+        // Serialize key package claims: MockMLSActionsProviderProtocol's generated
+        // invocation-recording arrays aren't thread-safe, so concurrent claims would race.
+        createSut(maxConcurrentKeyPackageClaims: 1)
+
         let groupID = MLSGroupID(Data([1, 2, 3]))
         let removalKey = Data([1, 2, 3])
         let users = [

wire-ios-data-model/Tests/Source/Model/Messages/ZMMessageTests+Confirmation.swift

@@ -57,6 +57,32 @@ extension ZMMessageTests_Confirmation {
         XCTAssertFalse(message.needsReadConfirmation)
     }
 
+    func testThatMessageDoesntNeedReadConfirmation_InAnMLSGroup_WhenItExpectsReadConfirmation() {
+        // given
+        let user = createUser(in: uiMOC)
+        let conversation = createConversation(in: uiMOC)
+        conversation.messageProtocol = .mls
+
+        let message = insertMessage(conversation, fromSender: user, timestamp: Date()) as! ZMClientMessage
+        message.expectsReadConfirmation = true
+
+        // then
+        XCTAssertFalse(message.needsReadConfirmation)
+    }
+
+    func testThatMessageNeedsReadConfirmation_InAMixedGroup_WhenItExpectsReadConfirmation() {
+        // given
+        let user = createUser(in: uiMOC)
+        let conversation = createConversation(in: uiMOC)
+        conversation.messageProtocol = .mixed
+
+        let message = insertMessage(conversation, fromSender: user, timestamp: Date()) as! ZMClientMessage
+        message.expectsReadConfirmation = true
+
+        // then
+        XCTAssertTrue(message.needsReadConfirmation)
+    }
+
     func testThatMessageDoesntExpectReadConfirmation_InAGroup_ForMessagesSentBySelfUser() {
         // given
         let conversation = createConversation(in: uiMOC)